test: add firehose tests #5652
Merged
test: add firehose tests #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the synchronous 'firehose' test - from PR #5650 - to all operators for which it is meaningful.
The following operators currently fail and are skipped:
catchErrorexhaustexhaustMapmulticastraceWithrefCountrepeatrepeatWhenretryretryWhenshareshareReplaysingleskipLastthrottletimeouttimeoutWithSome of the failures are likely dependent - e.g.
sharefails because eithermulticastorrefCountfails.Whether or not the failures should be fixed in this PR or in subsequent PRs, IDK. Anyway, at least we now have the tests.
Also, the PR renames some spec source files to match the operator name and to identify 'legacy' tests - some existing files were identified as such, but others were not.
Related issue (if exists): #5650