feat: add ObservedValueUnion/TupleFromArray #5254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
changed the title
cartant
force-pushed
the
observable-value-tuple
branch
2 times, most recently
from
cc6c979 to
c6c0afe
Compare
benlesh
approved these changes
Jan 22, 2020
| * Adds a type to the beginning of a tuple. | ||
| * If you pass in `Unshift<[B, C], A>` you will get back `[A, B, C]`. | ||
| */ | ||
| export type Unshift<X extends any[], Y> = |
There was a problem hiding this comment.
Nice! I wouldn't have thought to use extending a function to pull out the argument types. Very cool
For some reason, the number[] type shows up in seemingly random places in the union.
cartant
force-pushed
the
observable-value-tuple
branch
from
c6c0afe to
dc88b2b
Compare
kwonoj
pushed a commit
to kwonoj/rxjs
that referenced
this pull request
Feb 5, 2020
* feat: add observed value union and tuple types * chore: rename to use observed value union type * chore: tweak test to make dtslint deterministic For some reason, the number[] type shows up in seemingly random places in the union.
martinsik
pushed a commit
to martinsik/rxjs
that referenced
this pull request
Feb 15, 2020
* feat: add observed value union and tuple types * chore: rename to use observed value union type * chore: tweak test to make dtslint deterministic For some reason, the number[] type shows up in seemingly random places in the union.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR:
ObservedValuesFromArraytype toObservedValueUnionFromArrayand deprecates the former.ObservedValueTupleFromArraytype.The differences between the two are best shown by example:
It also adds an
Unshifttype - which adds a type to the beginning of a tuple - that should be useful in typing thecombineLatestWithandzipWithoperators.These types should be sufficient to allow for N-args support in those operators:
Related
issuePRs: #5249; #5251