Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dematerialize): add dematerialize operator #479

Closed
wants to merge 2 commits into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 7, 2015

  • add dematerialize operator
  • add marble test case for materialize, dematerialize operator

closes #391, #475

Effort to try close above 2 opened issues. Migrated RxJS4 tests for materialize operator, added coverage for dematerialize as well.

@benlesh
Copy link
Member

benlesh commented Oct 7, 2015

@kwonoj, can you break this into two commits? I tried to do it myself, but I can't do it without putting the commits under my name.

basically it's just git reset HEAD~, then git add the files individually before your commit.

The two commits I'd like are:

  1. feat(dematerialize): add demat... (your text here)
  2. test(materialize): add tests for ... (your text here)

.. be sure to include the issue numbers they close.

Again, I'm happy to do this for you, I just don't want you to lose your github "cred". ;)

@kwonoj
Copy link
Member Author

kwonoj commented Oct 7, 2015

Sure, I'll give it a try and update PR.

- add dematerialize operator
- add test coverage for dematerialize operator

closes ReactiveX#475
@kwonoj kwonoj changed the title feat(operator): add dematerialize operator feat(dematerialize): add dematerialize operator Oct 7, 2015
@kwonoj
Copy link
Member Author

kwonoj commented Oct 7, 2015

Update PR to contain 2 separated commits for adding dematerialize operator and expanding test coverage for materialize.

@benlesh
Copy link
Member

benlesh commented Oct 8, 2015

Merged with ff1a7f9! Thanks, as always @kwonoj. :)

@benlesh benlesh closed this Oct 8, 2015
@kwonoj kwonoj deleted the operator-dematerialize branch October 8, 2015 22:49
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comprehensive marble tests for materialize
2 participants