Error rework #4765
Error rework #4765
Conversation
|
There's something crazy going on with Travis... It's installing node 0.10. Not sure why it started doing that... I hate CI configuration. 🙄 |
benlesh
force-pushed
the
error-checkers
branch
2 times, most recently
from
4959bd5 to
a96f706
Compare
Adds error checking utilities: , , , , .
BREAKING CHANGE: ArgumentOutOfRangeError message is now just `'out of range'`, use `isOutOfRangeError` util to identify.
To test for empty errors, use `isEmptyError`.
Use `isObjectUnsubscribedError` to test for this error type.
Use `isTimeoutError` to test. BREAKING CHANGE: TimeoutError message is now `observable timed out`.
To test for errors that have occurred during teardown, use `isTeardownError`
| */ | ||
| export function createRxError(message: string, code: RxErrorCode, ErrorType: any = Error) { | ||
| const result = new ErrorType('RxJS: ' + message); | ||
| (result as any).__rxjsErrorCode = code; |
There was a problem hiding this comment.
Would there be any advantage in using a symbol instead of a string key for the __rxjsErrorCode property?
There was a problem hiding this comment.
There would be one disadvantage, which is it wouldn't work in IE. that's really it.
internal refactor
| ObjectUnsubscribed = 2, | ||
| Timeout = 3, | ||
| Teardown = 4, | ||
| } |
There was a problem hiding this comment.
We cannot use const enums. It will break with isolated modules. They cannot even be exported within internal modules, IIRC.
There was a problem hiding this comment.
IMO, we should get this - or something very much like it - merged: #4677
I missed the const enum in my first review. And that's something that's likely to be overlooked again and again.
|
I'm going to close this for now. We still want to do something like this, but I'm not sure 7.0 is the time to do it |
The first step in getting rid of custom errors to help reduce bundle sizes. Please see design doc here.