Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(endWith): ability to endWith different types (#4183) #4185

Merged
merged 1 commit into from
Oct 10, 2018
Merged

fix(endWith): ability to endWith different types (#4183) #4185

merged 1 commit into from
Oct 10, 2018

Conversation

dkosasih
Copy link
Contributor

Description: add ability for endWith operator to end the Observable with different types.

Related issue (if exists): #4183

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.808% when pulling d08f235 on dkosasih:endWith-mix_types into 7eeb671 on ReactiveX:master.

cartant
cartant approved these changes Sep 27, 2018
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit 83533d1 into ReactiveX:master Oct 10, 2018
@benlesh
Copy link
Member

benlesh commented Oct 10, 2018

Thanks, @dkosasih!

@lock lock bot locked as resolved and limited conversation to collaborators Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh benlesh approved these changes

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkosasih @coveralls @benlesh @cartant