Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add dtslint files and script #3944

Merged
merged 4 commits into from
Jul 25, 2018
Merged

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jul 23, 2018

Description:

This PR adds dtslint to the full-validation build. The dtslint-related files are in the spec-dtslint directory.

The type tests for the zip factory function and the zip operator have been included so that they are tested using dtslint's expectations. The original type tests have not been removed.

Related issue (if exists): #3823

@rxjs-bot
Copy link

rxjs-bot commented Jul 23, 2018

Warnings
⚠️

❗ Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Jul 23, 2018

Coverage Status

Coverage remained the same at 96.962% when pulling 6c4008c on cartant:issue-3823 into a3323fc on ReactiveX:master.

@cartant
Copy link
Collaborator Author

cartant commented Jul 23, 2018

Hmm. I hadn't noticed that npm had made such a mess of the lock file. I will try to fix it up a little.

@kwonoj
Copy link
Member

kwonoj commented Jul 23, 2018

though lockfile itself seems ok-change?

@cartant
Copy link
Collaborator Author

cartant commented Jul 23, 2018

I'm just going to re-apply the commits and do a single install of dtslint using the current lock file from master. I'm not going to manually mess with the lock file.

The initial commits and install of dtslint were from some time ago and I had to re-install dtslint to get an updated dependency - as I'm creating this PR on a different computer - and I really don't think that the lock file should have as many changes in it as it appears to have. I'd like to be sure that what was in the node_modules directory on this computer hasn't messed with the lock file. npm infuriates me sometimes.

@cartant
Copy link
Collaborator Author

cartant commented Jul 24, 2018

@kwonoj I'm done messing with this. I don't know why npm does some of the things that it does. E.g. it appears to have changed resolved from false to an empty string for a bunch of entries.

Anyway, I'm at least confident that there wasn't any filth in node_modules that could have effected an unwarranted changes to the lock file.

@benlesh benlesh merged commit 0f4c532 into ReactiveX:master Jul 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2018
@cartant cartant deleted the issue-3823 branch September 24, 2020 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants