Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove comments from js-files #3760

Merged
merged 1 commit into from
Jun 4, 2018
Merged

perf: remove comments from js-files #3760

merged 1 commit into from
Jun 4, 2018

Conversation

csvn
Copy link
Contributor

@csvn csvn commented May 29, 2018

Description:

Strip comments from all .js files (except legacy-reexports and compat) while retaining them for .d.ts files. The legacy-reexport does not have any comments and will be removed with compat in next major version.

npx get-folder-size --folder=dist/package
// 5.88 Mb (with comments)
// 4.63 Mb (without comments)

Roughly 1.25 Mb is saved by removing comments.

Related issue (if exists): #3753

Strip comments from all .js files (except legacy-reexports and compat) while retaining them for .d.ts files. The legacy-reexport does not have any comments and will be removed with compat in next major version.

```
npx get-folder-size --folder=dist/package
// 5.88 Mb (with comments)
// 4.63 Mb (without comments)
```

Roughly 1.25 Mb is saved by removing comments.
@csvn
Copy link
Contributor Author

csvn commented May 29, 2018

If you are wondering why build_types is slightly out of order in build_all, it's because it has to come before build_legacy_reexports, since the latter uses ./dist/typings.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.656% when pulling ac2976e on csvn:reduce-disk-size into d7bfc9d on ReactiveX:master.

@benlesh benlesh requested a review from cartant May 31, 2018 20:00
@benlesh
Copy link
Member

benlesh commented May 31, 2018

LGTM... @cartant second opinion?

Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit bb2c334 into ReactiveX:master Jun 4, 2018
@benlesh
Copy link
Member

benlesh commented Jun 4, 2018

Thanks @csvn!

@csvn csvn deleted the reduce-disk-size branch June 4, 2018 21:42
@lock lock bot locked as resolved and limited conversation to collaborators Jul 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants