Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): fix operator test types p-z #3731

Merged
merged 28 commits into from
May 24, 2018
Merged

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented May 22, 2018

Description:

Continues from PR #3680 and fixes operators tests for operators starting with p through to z.

Related issue (if exists): #3411 #3680

@cartant cartant changed the title chore(test): fix operator test types m-z chore(test): fix operator test types p-z May 22, 2018
rxTestScheduler must be obtained via the global, as that's how it's
configured before each test. It won't be defined at module import time.
@coveralls
Copy link

coveralls commented May 22, 2018

Coverage Status

Coverage decreased (-0.03%) to 96.865% when pulling dd61c8e on cartant:issue-3411-5 into c05a945 on ReactiveX:master.

@cartant
Copy link
Collaborator Author

cartant commented May 23, 2018

I'm going to have to rebase each of these PRs after each's preceding PR is merged.

GitHub doesn't seem to support PR dependencies. And the only way I can see to get the merge to work without a rebase involves either having failing tests or cumulative commits that GitHub doesn't remove/hide from the PR when the same commits are merged in a preceding PR is merged.

Either way, it's just as annoying as rebasing.

@benlesh benlesh merged commit 849f4d3 into ReactiveX:master May 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 23, 2018
@cartant cartant deleted the issue-3411-5 branch September 24, 2020 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants