fix(delay): fix memory leak (in stable) #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test(delay): failing test * fix(delay): fix memory leak
Generated by 🚫 dangerJS |
---3.6KB-green.svg?style=flat-square){kind=icon}
---0.1KB-green.svg?style=flat-square){kind=icon}
benlesh
approved these changes
May 9, 2018
|
@cartant ... I'm torn on this, if we patch 5.x, we'll also need to patch 5.6.0-forward-compat. At some point we're going to need to move on (unless there's some glaring security issue). |
|
cc @kwonoj |
benlesh
added
AGENDA ITEM
|
@benlesh Yeah, I get that not all fixes should be backported, but memory leaks are especially insidious. And the I guess it depends upon how many apps using v5 would benefit from the fix. To benefit, they'd have to be using I don't have a strong opinion either way, but I'd favour backporting. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR cherry picks PR #3605 into the
stablebranch. Given that it fixes a memory leak, I think there's something to be said for its application to v5, too.Related issue (if exists): #3604