Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AsapScheduler): Fix issue where canceling an asap or animationFrame action early could throw #2638

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

trxcllnt
Copy link
Member

@trxcllnt trxcllnt commented Jun 3, 2017

Fixes #2594 and #2625. props to @dreamershl for pinpointing the fix!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.735% when pulling f20bc89 on trxcllnt:fix-asap-early-unsubscribe into a7af560 on ReactiveX:master.

@kwonoj
Copy link
Member

kwonoj commented Jun 3, 2017

I guess this should be patch release?

@trxcllnt
Copy link
Member Author

trxcllnt commented Jun 4, 2017

@kwonoj yes I believe so

@kwonoj kwonoj requested a review from benlesh June 12, 2017 16:50
@benlesh benlesh merged commit fc39043 into ReactiveX:master Jun 14, 2017
@trxcllnt trxcllnt deleted the fix-asap-early-unsubscribe branch June 15, 2017 19:19
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asap scheduler throws error with limiting interval via take
4 participants