Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AsyncAction): Make AsyncAction update its timeout if rescheduled before its executed #2580

Merged
merged 1 commit into from
May 2, 2017

Conversation

trxcllnt
Copy link
Member

Rescheduling an async action with the same due time before its executed should cause it to cancel
its current interval and schedule a new one.

Fixes #2579

…before its executed.

Rescheduling an async action with the same due time before its executed should cause it to cancel
its current interval and schedule a new one.

2579
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 97.629% when pulling b9d2bc8 on trxcllnt:fix-async-pending-reschedule into e69d876 on ReactiveX:master.

@kwonoj kwonoj requested a review from benlesh April 30, 2017 21:17
@kwonoj
Copy link
Member

kwonoj commented May 2, 2017

I guess this can be patch release?

@trxcllnt
Copy link
Member Author

trxcllnt commented May 2, 2017

@kwonoj I believe so, as it's a backwards-compatible bugfix

@benlesh
Copy link
Member

benlesh commented May 2, 2017

Looks good @trxcllnt ... Also points out how tricky this implementation is. haha.

:shipit:

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants