Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): add missing babel-polyfill to package.json #2576

Merged
merged 1 commit into from
Apr 24, 2017
Merged

fix(tests): add missing babel-polyfill to package.json #2576

merged 1 commit into from
Apr 24, 2017

Conversation

mpodlasin
Copy link
Contributor

Add missing babel-polyfill to package.json, so that tests
run in the browsers that do not support ES6 features run
without issues.

Closes #2261

Dependency is used here: https://github.com/ReactiveX/rxjs/blob/master/spec/support/mocha-browser-runner.html#L11

Add missing babel-polyfill to package.json, so that tests
run in the browsers that do not support ES6 features run
without issues.

Closes #2261
@kwonoj
Copy link
Member

kwonoj commented Apr 24, 2017

I'll check this in right away once CI returns.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.644% when pulling b277ce9 on Podlas29:add-missing-babel-polyfill into e387113 on ReactiveX:master.

@kwonoj kwonoj merged commit 04b898e into ReactiveX:master Apr 24, 2017
@kwonoj
Copy link
Member

kwonoj commented Apr 24, 2017

Thanks for finding this out, this was long pain 👏

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants