fix(ErrorObservable): remove type constraint to error value #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
requested changes
Feb 21, 2017
src/observable/ErrorObservable.ts
Outdated
| @@ -63,7 +63,7 @@ export class ErrorObservable<T> extends Observable<any> { | |||
| subscriber.error(error); | |||
| } | |||
|
|
|||
| constructor(public error: T, private scheduler?: IScheduler) { | |||
| constructor(public readonly error: any, private readonly scheduler?: IScheduler) { | |||
There was a problem hiding this comment.
yes, we've done similar (#2249) and we've accepted to introduce those changes, since it brings explicit clarification for TS users.
There was a problem hiding this comment.
Either case I've updated code as it can be easily created as separate PR.
kwonoj
force-pushed
the
fix-errorobservable-type
branch
from
5acaafc
to
2f951cd
Compare
benlesh
approved these changes
Feb 21, 2017
|
Hi guys, Change is easy but should not be this marked as BC ? @benlesh |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates type signature of static creation method for
ErrorObservableto no longer carry type constraint to value of error.Related issue (if exists):