Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] Introduce nuget specification file pending nuget package #2293

Closed
wants to merge 1 commit into from

Conversation

ichpuchtli
Copy link
Contributor

@ichpuchtli ichpuchtli commented Jan 18, 2017

Description:
Introduce nuspec (nuget equivalent of package.json). Something to get the ball rolling towards having a nuget package for rxjs 5.

TODO

Related issue (if exists):
Fixes issue #1361

image

@kwonoj
Copy link
Member

kwonoj commented Jan 18, 2017

#1481 is now tracked at #2221.

@coveralls
Copy link

coveralls commented Jan 18, 2017

Coverage Status

Coverage remained the same at 97.698% when pulling 89295da on ichpuchtli:patch-2 into 31cf2bf on ReactiveX:master.

@ichpuchtli
Copy link
Contributor Author

I've published an unlisted/unsearchable nuget package test-rxjs5 for testing https://www.nuget.org/packages/test-rxjs5

Copy link
Member

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work on a script to generate the .nuspec file on prepublish. This will lower maintenance costs and make this more palatable for the team.

<package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
<metadata>
<id>rxjs</id>
<version>5.0.3</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do something to keep this in sync... in fact all of this data... the author email, the version, etc... should be pulled from the package.json when we publish. I think I'd be more in favor of this if it included a script to do so, so I wouldn't have to keep it up to date on each publish.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, i'll see what I can do.

@benlesh
Copy link
Member

benlesh commented Jan 23, 2018

Closing as stale.

@benlesh benlesh closed this Jan 23, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants