fix(operator/do): fix typings

[Brooooooklyn]

Description:

Observable.of('abc')
  .do(v => {
    // type of v is { } here
    console.log(v.substr(2))
  })

Related issue (if exists):

[coveralls]

Coverage remained the same at 97.039% when pulling 448c4e0 on Brooooooklyn:issue/do-type into 1bee98a on ReactiveX:master.

[kwonoj]

This looks ok to me, @david-driscoll is this caused by script running? or current state is expected?

[benlesh]

This looks fine to me, pending @david-driscoll's approval (because it's typings related)

[david-driscoll]

One more change, then this is good.

[david-driscoll]

definitely something I missed with the script. This needs to be changed slightly, note the additional this: Observable<T> .

complete?: (this: Observable<T>) => void should be changed back to complete?: () => void

[Brooooooklyn]

fixed

[coveralls]

Coverage remained the same at 97.039% when pulling 9a40297 on Brooooooklyn:issue/do-type into 1bee98a on ReactiveX:master.

[david-driscoll]

LGTM

[coveralls]

Coverage remained the same at 97.041% when pulling 910c3fe on Brooooooklyn:issue/do-type into 5460e77 on ReactiveX:master.

[kwonoj]

LGTM

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.