Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operators): export reserved name operators on prototype #1927

Merged
merged 1 commit into from
Sep 9, 2016

Conversation

robwormald
Copy link
Contributor

@robwormald robwormald commented Sep 8, 2016

closes #1924

@robwormald
Copy link
Contributor Author

cc @IgorMinar

@jayphelps
Copy link
Member

Had an extraneous semicolon that was failing the build, so I removed it. Used it as an opportunity to try out the new ability for maintainers to modify submitted PR branches directly (even push -f!!) So handy.

Although I don't like this solution, I can't think of any other one. This whole underscore business is unfortunate to begin with. So that said, I think this is acceptable.

I'll wait a few days to see if anyone wants to object?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.129% when pulling 3aeed8e on robwormald:fix-proto into af4e6a9 on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Sep 9, 2016

LGTM

@benlesh
Copy link
Member

benlesh commented Sep 9, 2016

Needs rebase tho

@coveralls
Copy link

coveralls commented Sep 9, 2016

Coverage Status

Coverage increased (+0.002%) to 97.129% when pulling 34c39dd on robwormald:fix-proto into 5a498f3 on ReactiveX:master.

@IgorMinar
Copy link
Contributor

rebased as #1932

@jayphelps
Copy link
Member

@IgorMinar I rebased this already, is that the only change?

@IgorMinar
Copy link
Contributor

@jayphelps I just rebased. no other changes.

@jayphelps jayphelps merged commit d11b564 into ReactiveX:master Sep 9, 2016
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_catch vs catch breaks ESM code built against the rxjs umd bundle
5 participants