fix(WebSocketSubject): prevent early close #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2016
|
I think additional test case can be added for this behavior changes. (check stub socket.close being called only if condition mets) |
deontologician
force-pushed
the
websocket_keep_open
branch
from
b884ba0 to
eb7c55f
Compare
deontologician
force-pushed
the
websocket_keep_open
branch
from
eb7c55f to
543131c
Compare
|
Alright, test added. I've confirmed it fails on master and succeeds on this branch (on master the second |
deontologician
pushed a commit
to rethinkdb/horizon
that referenced
this pull request
Jul 18, 2016
Needed until ReactiveX/rxjs#1831 is merged
|
Has anyone had a chance to check this out? |
|
For me this change looks ok, need other reviewer's approval as well. |
|
LGTM |
|
Thanks! |
32bitkid
pushed a commit
to niolabs/zenith-client
that referenced
this pull request
Jun 1, 2017
Needed until ReactiveX/rxjs#1831 is merged
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This prevents the WebSocketSubject from prematurely closing the underlying websocket before all subscriptions have completed.
Related issue (if exists):
#1827