Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIG: Subject rewrite #1701

Merged
merged 11 commits into from
May 22, 2016
Merged

BIG: Subject rewrite #1701

merged 11 commits into from
May 22, 2016

Commits on May 22, 2016

  1. refactor(ISubcription): remove add and remove methods from interface

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    08f3d38 View commit details
    Browse the repository at this point in the history

  2. fix(Subject): correct Subject behaviors to be more like Rx4 

    BREAKING CHANGE: Subjects no longer duck-type as Subscriptions
BREAKING CHANGE: Subjects will no longer throw when re-subscribed to if they are not unsubscribed
BREAKING CHANGE: Subjects no longer automatically unsubscribe when completed or errored
BREAKING CAHNGE: Minor scheduling changes to groupBy to ensure proper emission ordering
    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    ba9ef2b View commit details
    Browse the repository at this point in the history

  3. refactor(SubjectSubscription): add check for isStopped to fast return

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    a5f50f3 View commit details
    Browse the repository at this point in the history

  4. style(lint): fix lint

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    55d5141 View commit details
    Browse the repository at this point in the history

  5. fix(AnonymousSubject): allow anonymous observers as destination

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    0e2c28b View commit details
    Browse the repository at this point in the history

  6. refactor(toSubscriber): readd use of rxSubscriber symbol

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    a770f46 View commit details
    Browse the repository at this point in the history

  7. refactor(Subject): ensure _subscribe is protected

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    5d49cad View commit details
    Browse the repository at this point in the history

  8. refactor(ReplaySubject): rename private properties for consistency

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    9022aaa View commit details
    Browse the repository at this point in the history

  9. refactor(ConnectableObservable): refactored to accommodate new Subjec… 

    …t structure
    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    3a9d4e6 View commit details
    Browse the repository at this point in the history

  10. refactor(ReplaySubject): revert change to defaulted scheduler

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    fce1a5e View commit details
    Browse the repository at this point in the history

  11. refactor(WebSocketSubject): _output is now private

    @benlesh
    benlesh committed May 22, 2016
    Configuration menu
    Copy the full SHA
    843176d View commit details
    Browse the repository at this point in the history