fix(scan): accumulator passes current index #1632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,23 +32,23 @@ import {Subscriber} from '../Subscriber'; | |||
| * @see {@link mergeScan} | |||
| * @see {@link reduce} | |||
| * | |||
| * @param {function(acc: R, value: T): R} accumulator The accumulator function | |||
| * @param {function(acc: R, value: T, , index: number): R} accumulator The accumulator function | |||
There was a problem hiding this comment.
@kwonoj Can you fix these commas? Should be , not , ,. Also limiting the line width to 80 chars would be good.
|
Besides the comment I placed in code, looks good to merge in my opinion. |
|
I'll check this in later today if there isn't other suggestions around. |
|
Merged with a3ec896. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds small changes to
accumulatorofscanto pass index of source. Still does not passes source observable.Related issue (if exists):
closes #1614