Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): don't expose PromiseConstructor dependency #1276

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

Fixes #1270

(Note: in angular we have a "test.typings" task, which takes the dist folder and ensures the user can type-check against it given pre-requisite dependencies. That would prevent this problem from returning)

@kwonoj
Copy link
Member

kwonoj commented Feb 1, 2016

Interesting PR, thanks for this. So does PromiseCtor is equivalent to typeof Promise?

@alexeagle
Copy link
Contributor Author

Yes, simply, because in lib.es6.d.ts

declare var Promise: PromiseConstructor;

It's a tricky distinction.
PromiseConstructor forces a particular constructor signature, static members, etc.
typeof Promise just means a factory of Promise instances.

@kwonoj
Copy link
Member

kwonoj commented Feb 1, 2016

Thanks @alexeagle , merged with f59225b. I've amended commit message from Fixed # to closes # to met with current convention we're using for automate changelogs, wish you don't mind :) Thanks again!

@kwonoj kwonoj closed this Feb 1, 2016
@alexeagle
Copy link
Contributor Author

@Blesh we need to hold the next angular2 release until this is released in rxjs (so that our quickstart guide doesn't need a temporary "install es6-shim.d.ts" step)
Any idea when the next release will land? thx!

@alexeagle alexeagle deleted the promisector branch February 3, 2016 17:23
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants