Missing doOn* operators

[luisgabriel]

It seems that doOnNext, doOnError and doOnCompleted are not implemented here yet.

Is it intentional or should we add them?

[staltz]

do(onNext, () => {}, () => {})

do(() => {}, onError, () => {})

do(() => {}, () => {}, onCompleted)

[mattpodwysocki]

@staltz that's not quite right if you look at the implementation: https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/perf/operators/tap.js#L55-L86

Since you're lacking the default behavior of the do semantics as well as lacking the thisArg

[benlesh]

@mattpodwysocki I'd personally like to do away with thisArg in the library, since we're only targeting browsers that have .bind() now, and ES7 function bind is coming.

[mattpodwysocki]

@Blesh that's fine but Function#bind is very slow and not likely to be much faster in the future, whereas the thisArg is rather performant in comparison. And if you indeed care about perf, then I'd keep it

[benlesh]

@staltz @luisgabriel ... simpler (and perhaps more explicit) in ES6:

obs.do({ error(err) { /* stuff */ } })

// or

obs.do({ error: (err) => /* stuff */ })

[benlesh]

Related, though, we should make sure do handles observers and null/undefined values passed to it.

[IanVS]

The migration guide does not mention the removal of the convenience functions doOnNext, doOnError, and doOnCompleted. Doesn't seem worth creating a new issue, but I thought I'd mention it here because it tripped me up a bit in my migration from 4.

[Karasuni]

The documentation http://reactivex.io/documentation/operators/do.html#collapseRxJS still mentions doOnNext, doOnError and doOnCompleted as part of rx.js.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.