Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe operator publishReplay cannot infer generic type. #3260

Closed
bowenni opened this issue Jan 25, 2018 · 2 comments · Fixed by #3437
Closed

Pipe operator publishReplay cannot infer generic type. #3260

bowenni opened this issue Jan 25, 2018 · 2 comments · Fixed by #3437
Assignees
@david-driscoll
Labels
TS Issues and PRs related purely to TypeScript issues

Comments

@bowenni
Copy link
Contributor

bowenni commented Jan 25, 2018

RxJS version:
5.5.0

Code to reproduce:

declare const obs: Observable<number>;
const temp: null = obs.pipe(publishReplay(1));

Expected behavior:
I'm expecting Type 'Observable<number>' is not assignable to type 'null'.

Actual behavior:
Type 'Observable<any>' is not assignable to type 'null'.
@benlesh benlesh added the TS Issues and PRs related purely to TypeScript issues label Jan 25, 2018
@benlesh
Copy link
Member

benlesh commented Jan 25, 2018

Thanks, @bowenni.

This could just be an issue with TypeScript. cc @david-driscoll, can you please have a look at this?

benlesh added a commit to benlesh/rxjs that referenced this issue Mar 15, 2018
@benlesh
fix(publishReplay): type inference improved
696d04e 
closes ReactiveX#3260
@benlesh benlesh mentioned this issue Mar 15, 2018
Merged
benlesh added a commit that referenced this issue Mar 15, 2018
@benlesh
fix(publishReplay): type inference improved (#3437)
dd7c9f1 
closes #3260
This was referenced Mar 19, 2018
Closed
Closed
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@david-driscoll david-driscoll

Labels
TS Issues and PRs related purely to TypeScript issues
Projects
None yet
Milestone
No milestone
3 participants
@david-driscoll @benlesh @bowenni