-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue when importing/using Rxjs with 5.5.3 version #3155
Comments
This may related with #3025, haven't verified though. /cc @jasonaden . |
Can be fixed by doing The documentation should be fixed to reflect this, since the default import is still used in https://github.com/ReactiveX/rxjs#installation-and-usage |
Has import of the default been deprecated/removed or will it this be fixed in 5.5.4? |
Quick fix: But this is a breaking change for many people and should have been versioned accordingly. What are the plans for for 5.5.4? |
It is a regression, not an intentional breaking change. We'll try to get it fixed as soon as we can. |
The steps above don't repro the issue for me. Can someone please provide a way to reproduce this? Ideally create a repo with the problem so we can clone and see the issue. There must be something with environments or tools that I'm not seeing when simply using the above steps. |
|
I can verify this happening on React Native. |
same problem here. |
Apparently 5.5.3 was built with the wrong (newer) version of TypeScript, and that's what's causing the issue. Will build properly and publish again soon. |
This should be resolved in 5.5.4 now. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
RxJS version:
5.5.3
Code to reproduce:
import Rx from 'rxjs/Rx'; //same with from 'rxjs'
let observable = new Rx.Subject();
Expected behavior:
a new Rx.Subject is created
Actual behavior:
no Rx.Subject is created, get an error:
TypeError: Cannot read property 'Subject' of undefined
Additional information:
This was working fine with 5.5.2 code, and broke with 5.5.3
node v8.9.1
breaks when running using babel, ex: node -r babel-register foo.js
works when running es modules nativly, ex: node --experimental-modules foo.mjs
The text was updated successfully, but these errors were encountered: