Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: No more KitchenSink #1650

Closed
benlesh opened this issue Apr 25, 2016 · 6 comments · Fixed by #1663
Closed

Proposal: No more KitchenSink #1650

benlesh opened this issue Apr 25, 2016 · 6 comments · Fixed by #1663
Labels
help wanted Issues we wouldn't mind assistance with.
Milestone
5.0.0 release

Comments

@benlesh
Copy link
Member

benlesh commented Apr 25, 2016

We should probably just have one global export file for the masses.

  1. Is it huge? Yes.
  2. Should people use RxJS 5 that way? Hell no. Use a bundler and only import what you're using.
  3. In past tests, I noticed the gzipped size of Rx.KitchenSink.min.js was about the same as Rx.min.js, because of how the compression affected it.

If people are using the global export version of RxJS, it can be assumed that they're probably hacking around, and/or not really serious about reducing the size of their downloaded application.

At this point it's a little confusing to say "this is in Rx, but this is in Kitchensink" to people. Also, given how modular this library is, it would be easy enough for anyone to make their own custom build of RxJS 5 to keep around.

Basically the idea is just to put everything in Rx.ts

Thoughts?
@kwonoj
Copy link
Member

kwonoj commented Apr 26, 2016

I'm in favor of this in general too, but had assumption those packages are similar representation of rx.all.js to rx.lite.js in RxJS4. So in case of anyone who'd like to have minimal, core packages (Rx currently), it's recommended to make custom imported builds of their own?

@staltz staltz mentioned this issue Apr 26, 2016
Closed
@staltz
Copy link
Member

staltz commented Apr 26, 2016

Agreed.

@trxcllnt
Copy link
Member

Been in favor of this for a long time, let's do it.

@benlesh
Copy link
Member Author

benlesh commented Apr 28, 2016

So in case of anyone who'd like to have minimal, core packages (Rx currently), it's recommended to make custom imported builds of their own?

Yes. If someone cares that much they should be using bundling and tree shaking anyhow.

@benlesh benlesh added help wanted Issues we wouldn't mind assistance with. priority: high and removed type: discussion labels Apr 28, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Apr 28, 2016
@kwonoj
chore(Rx): remove kitchenSink, let Rx exports all
ab35e2f 
closes ReactiveX#1650
@kwonoj kwonoj mentioned this issue Apr 28, 2016
Merged
@benlesh benlesh modified the milestone: 5.0.0 release Apr 29, 2016
kwonoj added a commit to kwonoj/rxjs that referenced this issue Apr 30, 2016
@kwonoj
chore(Rx): remove kitchenSink and DOM, let Rx exports all
33e4ee6 
closes ReactiveX#1650
kwonoj added a commit to kwonoj/rxjs that referenced this issue Apr 30, 2016
@kwonoj
chore(Rx): remove kitchenSink and DOM, let Rx exports all
e9ec2f3 
closes ReactiveX#1650
kwonoj added a commit to kwonoj/rxjs that referenced this issue Apr 30, 2016
@kwonoj
chore(Rx): remove kitchenSink and DOM, let Rx exports all
033497d 
closes ReactiveX#1650
kwonoj added a commit to kwonoj/rxjs that referenced this issue Apr 30, 2016
@kwonoj
fix(Rx): remove kitchenSink and DOM, let Rx exports all
11d69c3 
closes ReactiveX#1650

BREAKING CHANGE: `Rx.kitchenSink` and `Rx.DOM` are not removed, `Rx`
exports everything.
kwonoj added a commit to kwonoj/rxjs that referenced this issue Apr 30, 2016
@kwonoj
fix(Rx): remove kitchenSink and DOM, let Rx export all
f5090b4 
closes ReactiveX#1650

BREAKING CHANGE: `Rx.kitchenSink` and `Rx.DOM` are removed, `Rx`
export everything.
@zertosh
Copy link
Contributor

zertosh commented May 1, 2016

I would love to see this go out in a beta 8.

@zertosh zertosh mentioned this issue May 8, 2016
Closed
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
5.0.0 release
Development

Successfully merging a pull request may close this issue.

fix(Rx): remove kitchenSink and DOM, let Rx exports all kwonoj/rxjs
5 participants
@staltz @trxcllnt @zertosh @kwonoj @benlesh