This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
Added PWA capability and updated styling #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
approved these changes
Oct 2, 2017
ladyleet
suggested changes
Oct 2, 2017
There was a problem hiding this comment.
Hey @btroncone! Amaze first PR! Super small changes related to the default cli selectors. Happy to hear comments/thoughts! :) I just hate breaking convention here.
src/app/team/team.component.ts
Outdated
| @@ -1,9 +1,9 @@ | |||
| import { Component, OnInit } from '@angular/core'; | |||
|
|
|||
| @Component({ | |||
| selector: 'app-team', | |||
| selector: 'rx-team', | |||
There was a problem hiding this comment.
@btroncone i don't love changing the selectors or the conventions that the cli gives us - any good reason why?
There was a problem hiding this comment.
It's more habit than anything, I generally adjust prefix to be app specific. I'm perfectly fine with app though, I'll update real quick. 👍
src/index.html
Outdated
| </head> | ||
| <body> | ||
| <app-root></app-root> | ||
| <rx-root></rx-root> |
There was a problem hiding this comment.
same comments as last comment on changing default selectors
6 tasks
|
I updated the prefix back to |
|
@btroncone woot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates to the project include:
@angular/service-workerscssrx