Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Design a teams page #14

Closed
ladyleet opened this issue Oct 2, 2017 · 19 comments · Fixed by #231
Closed

Design a teams page #14

ladyleet opened this issue Oct 2, 2017 · 19 comments · Fixed by #231

Comments

@ladyleet
Copy link
Member

ladyleet commented Oct 2, 2017

[ ] Design page for approval
[ ] Core team
[ ] Learning team

@fredrik-lundin
Copy link
Contributor

fredrik-lundin commented Oct 3, 2017

How big are the core and learning teams (approximately)? Does it make sense to somehow split the screen either in two sub-pages or tabs. Or is the number of people small enough to fit on one screen (which usual is preferable if possible I guess).

Also, what kind of data do we want to present? Name, short bio, picture? Contact information?

@ladyleet

@ladyleet
Copy link
Member Author

ladyleet commented Oct 3, 2017

@fredrik-lundin pretty small! I would say 5-10 people max for each category? One screen is preferred. Name, Short Bio (2 sentences max), Picture, Twitter, Github, LinkedIn?

@fredrik-lundin
Copy link
Contributor

@ladyleet alright, great!

I'm a bit unsure if I'll have to time work on it this week, as I'll be traveling for a few days. If someone starts looking at this before I can get too it, I'll just try to tag along when I get back. If not, I'll start working on it hopefully next week 😄

@ladyleet
Copy link
Member Author

ladyleet commented Oct 3, 2017

@fredrik-lundin for sure! i really appreciate you lending a hand! thank you so much in advance! :)

fredrik-lundin added a commit to fredrik-lundin/rxjs-docs that referenced this issue Oct 16, 2017
@fredrik-lundin
Copy link
Contributor

@ladyleet hey, I finally got to start playing around a bit with this page. I noticed very quickly though that it's really hard since we don't have any design guidelines or basic styling in place. That makes it very hard to style or design anything, since I feel like I might be completely misaligned with the rest of the people working on this.

It would be very useful to have some kind of core design in place. Basic things like:

  • How wide is the main content area
  • How are we doing in terms of responsive design (some set breakpoints?)
  • Common styling for basic elements like header, sections, field sets, etc

Maybe those points belongs to a separate issue though :)

@fredrik-lundin
Copy link
Contributor

Here is a first, very simply, idea. Just cards with a small avatar (can for example use the one from github, github.com/user-name.png). Name, role, bio, links. Then just different background colors for Core and Learning team

team-first-wip

@ladyleet
Copy link
Member Author

Hi @fredrik-lundin! thank you so much! That is basically exactly what we are looking for. I would emphasize the images and perhaps iterate on something like this?

screenshot 2017-10-19 09 58 51

@xlozinguez
Copy link

Can the team be extracted from the list of github contributors in order to avoid manual maintenance as much as can be?

@ladyleet
Copy link
Member Author

@xlozinguez nope - it's a pretty small list and doesn't change often so it should not be that high maintenance.

@fredrik-lundin
Copy link
Contributor

@ladyleet - working on something like this. Some tweaks to the text styling probably needed, but this should be more aligned with what you are thinking, right?

image

@ladyleet
Copy link
Member Author

@fredrik-lundin awesome! looking forward to seeing that PR!

@Only1MrAnderson
Copy link
Contributor

@fredrik-lundin Are you able to submit your work for this? If not I will pick it up.

@fredrik-lundin
Copy link
Contributor

@Only1MrAnderson Hi! I'm so sorry that I haven't had time to work on this at all in so long. Completely side tracked by.. life.. I will look into finishing up a PR this weekend. Or would you rather start from scratch?

@ladyleet
Copy link
Member Author

@fredrik-lundin have any time to finish this up? let me know what support you need from me!

@sumitarora
Copy link
Collaborator

@fredrik-lundin Can you push the PR whatever you have done?

@fredrik-lundin
Copy link
Contributor

Aaaargh, sorrryy!! I'll push what I have tonight!

@ladyleet
Copy link
Member Author

thanks @fredrik-lundin

@fredrik-lundin
Copy link
Contributor

@ladyleet submitted a PR!

@ladyleet
Copy link
Member Author

thanks @fredrik-lundin

knitcodemonkey pushed a commit to knitcodemonkey/rxjs-docs that referenced this issue Jan 10, 2018
convert the linkedIn link to a webpage link, update the color of said link, and finish adding details for team members

closes ReactiveX#14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants