Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITMS-91061: Missing privacy manifest #2625

Closed
pixnek opened this issue Aug 29, 2024 · 19 comments
Closed

ITMS-91061: Missing privacy manifest #2625

pixnek opened this issue Aug 29, 2024 · 19 comments

Comments

@pixnek
Copy link

pixnek commented Aug 29, 2024

after the review, I received an error with the text:
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxSwift.framework/RxSwift”, which includes OneSignalOutcomes, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
The same goes for: “Frameworks/RxRelay.framework/RxRelay” and “Frameworks/RxCocoa.framework/RxCocoa”
Can you help me? What should I do?

@pixnek pixnek changed the title error review need update privacy police error review Missing privacy manifest Aug 29, 2024
@fishofeyes
Copy link

+1

@freak4pc
Copy link
Member

Hey there
Can you share the full note you got from Apple ?

We have many apps with RxSwift that didn't get this warning

The warning you sent mentions "OneSignalOutcomes" but it's not part of the framework (we actually have no third party dependencies)

@fishofeyes
Copy link

fishofeyes commented Aug 29, 2024

I am using XCFrameworks, but I still received the Missing privacy manifest email from Apple.
image

Although submission for App Store review was successful, you may want to correct the following issues in your next submission for App Store review. Once you've corrected the issues, upload a new binary to App Store Connect.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxCocoa.framework/RxCocoa”, which includes RxCocoa, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxRelay.framework/RxRelay”, which includes RxRelay, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxSwift.framework/RxSwift”, which includes OneSignalOutcomes, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

Apple Developer Relations

@pixnek
Copy link
Author

pixnek commented Aug 29, 2024

UPD: Review was successful, but I received the following message:
Although submission for App Store review was successful, you may want to correct the following issues in your next submission for App Store review. Once you've corrected the issues, upload a new binary to App Store Connect.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxCocoa.framework/RxCocoa”, which includes RxCocoa, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxRelay.framework/RxRelay”, which includes RxRelay, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxSwift.framework/RxSwift”, which includes OneSignalOutcomes, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

Apple Developer Relations

@freak4pc
Copy link
Member

Thanks all -
This only affects entirely new apps - I also think they are wrong with the message but I also don't want to spend more time on it :)

If anyone wants to open a PR to add an empty privacy manifest (we dont have any privacy things happening in RxSwift), I'm happy to merge it.

@danielt1263
Copy link
Collaborator

danielt1263 commented Aug 30, 2024

I think such a PR already exists...

Here it is: #2572

@ct-ngyen
Copy link

ct-ngyen commented Sep 4, 2024

@freak4pc
@danielt1263
Hi all. i followed the topic #2567 and released some app without any problems.
But today, i summited app and also received the same issue again.
I googled ITMS-91061 topic and found some unsolved answers.
So probably there is new change about it which we don't know yet.
In this case, could you guys consider providing any solution such as inquiry Apple Developer Team or create the privacy manifest?

@freak4pc
Copy link
Member

freak4pc commented Sep 4, 2024

We'll probably add an empty manifest. Seems there is time until Nov, but I'll try to get to it soon.

@ct-ngyen
Copy link

ct-ngyen commented Sep 4, 2024

@freak4pc
Thanks for your quick response and understanding.
Please let me organize info we have so far.

According to DTS Engineer,
“If your framework doesn't require a privacy manifest, do nothing. Avoid adding an empty privacy manifest to your framework. Confirm that your framework doesn't repackage an SDK on the list of third-party SDKs requiring a privacy manifest and signature. If your framework does, then you need to add a privacy manifest to it.

-> Unfortunately, RxRelay, RxCoca, RxSwift which includes OneSignalOutcomes are in their list.
So adding empty privacy manifest is not recommended.

In this case, since there is no data to be declared, add No the data below can be considered.
(Pardon my amatuer solution)
Describe the data your app or third-party SDK collects
NSPrivacyCollectedDataType
NSPrivacyCollectedDataTypeLinked
NSPrivacyCollectedDataTypeTracking
NSPrivacyCollectedDataTypePurposes

And yess, since there is time until Nov, i do belied there will be solution to end this issue.

@freak4pc
Copy link
Member

freak4pc commented Sep 4, 2024

As I mentioned numerous times, OneSignal isn't part of RxSwift. This is a mis-fire.
You can see yourself that RxSwift (and others) have absolutely zero external dependencies:

.target(name: "RxSwift", dependencies: []),

@freak4pc freak4pc changed the title error review Missing privacy manifest ITMS-91061: Missing privacy manifest Sep 10, 2024
@liaoyc9
Copy link

liaoyc9 commented Sep 18, 2024

UPD:审核成功,但我收到以下消息: 尽管提交至 App Store 审核成功,但您可能需要在下次提交至 App Store 审核时更正以下问题。更正问题后,请将新的二进制文件上传至 App Store Connect。

ITMS-91061:缺少隐私清单 - 您的应用包含“Frameworks/RxCocoa.framework/RxCocoa”,其中包含 RxCocoa,该 SDK 在文档中被标识为影响隐私的第三方 SDK。从 2024 年 11 月 12 日开始,如果新应用包含影响隐私的 SDK,或者应用更新添加了新的影响隐私的 SDK,则 SDK 必须包含隐私清单文件。请联系包含此文件的 SDK 提供商以获取带有隐私清单的更新 SDK 版本。有关此政策的更多详细信息,包括需要包含签名和清单的 SDK 列表,请访问:https://developer.apple.com/support/third-party-SDK-requirements。

ITMS-91061:缺少隐私清单 - 您的应用包含“Frameworks/RxRelay.framework/RxRelay”,其中包含 RxRelay,该 SDK 在文档中被标识为影响隐私的第三方 SDK。从 2024 年 11 月 12 日起,如果新应用包含影响隐私的 SDK,或者应用更新添加了新的影响隐私的 SDK,则 SDK 必须包含隐私清单文件。请联系包含此文件的 SDK 提供商以获取带有隐私清单的更新 SDK 版本。有关此政策的更多详细信息,包括需要包含签名和清单的 SDK 列表,请访问:https://developer.apple.com/support/third-party-SDK-requirements。

ITMS-91061:缺少隐私清单 - 您的应用包含“Frameworks/RxSwift.framework/RxSwift”,其中包含 OneSignalOutcomes,该 SDK 在文档中被标识为影响隐私的第三方 SDK。从 2024 年 11 月 12 日起,如果新应用包含影响隐私的 SDK,或者应用更新添加了新的影响隐私的 SDK,则 SDK 必须包含隐私清单文件。请联系包含此文件的 SDK 提供商以获取带有隐私清单的更新 SDK 版本。有关此政策的更多详细信息,包括需要包含签名和清单的 SDK 列表,请访问:https://developer.apple.com/support/third-party-SDK-requirements。

Apple 开发者关系
我也收到了同样的邮件,希望大佬给尽快解决,在此表示万分感谢

@AlaghbariKamel
Copy link

AlaghbariKamel commented Sep 28, 2024

I still get the same massage after update to 6.7.1

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxCocoa.framework/RxCocoa”, which includes RxCocoa, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxRelay.framework/RxRelay”, which includes RxRelay, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/RxSwift.framework/RxSwift”, which includes OneSignalOutcomes, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting November 12, 2024, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.

@lili-shangshu
Copy link

+1

@hbyby
Copy link

hbyby commented Oct 2, 2024

+1,I also encountered the same problem, will this affect the app review and listing?

@freak4pc
Copy link
Member

freak4pc commented Oct 3, 2024

Hey there,
Please direct your apps at branch main directly and make sure it solves your problem.
If everything looks good I can cut an official release later this/next week.

Cheers 💪

@AlaghbariKamel
Copy link

Update all pods
Updating local specs repositories
Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "RxSwift":
In Podfile:
RxSwift (= 6.8.0)

None of your spec sources contain a spec satisfying the dependency: RxSwift (= 6.8.0).

You have either:

  • mistyped the name or version.
  • not added the source repo that hosts the Podspec to your Podfile.

@freak4pc
Copy link
Member

freak4pc commented Oct 6, 2024 via email

@AlaghbariKamel
Copy link

Try directing your Podfile directly to the main branch

On Sun, 6 Oct 2024 at 14:54 Kamel Alaghbari @.> wrote: Update all pods Updating local specs repositories Analyzing dependencies [!] CocoaPods could not find compatible versions for pod "RxSwift": In Podfile: RxSwift (= 6.8.0) None of your spec sources contain a spec satisfying the dependency: RxSwift (= 6.8.0). You have either: - mistyped the name or version. - not added the source repo that hosts the Podspec to your Podfile. — Reply to this email directly, view it on GitHub <#2625 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAETXFC5GWQ3UQ6V42B3ZMTZ2EQHFAVCNFSM6AAAAABNJX5FX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGQYTAMRTGU . You are receiving this because you were mentioned.Message ID: @.>

pod "RxSwift", :git => 'https://github.com/ReactiveX/RxSwift.git', :branch => '6.8.0'
pod "RxRelay", :git => 'https://github.com/ReactiveX/RxSwift.git', :branch => '6.8.0'
pod "RxCocoa", :git => 'https://github.com/ReactiveX/RxSwift.git', :branch => '6.8.0'

This worked with me
Yes thank you.
I will try to update my app on App Store and get you the result

@AlaghbariKamel
Copy link

AlaghbariKamel commented Oct 8, 2024

@freak4pc
I update my app on the Apple Store without any warnings from Apple.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants