Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Avoid using System.getProperties() due to security restrictions #6637

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

akarnokd
Copy link
Member

Change the code in the SchedulerPoolFactory to use System.getProperty directly. Also fix property names to rx3. as now both v2 and v3 could run together.

Fixes #6636

@akarnokd akarnokd added the 3.x label Aug 28, 2019
@akarnokd akarnokd added this to the 3.0 milestone Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #6637 into 3.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                3.x   #6637      +/-   ##
===========================================
+ Coverage     98.16%   98.2%   +0.03%     
- Complexity     6182    6195      +13     
===========================================
  Files           678     678              
  Lines         44801   44806       +5     
  Branches       6177    6177              
===========================================
+ Hits          43981   44002      +21     
+ Misses          278     276       -2     
+ Partials        542     528      -14
Impacted Files Coverage Δ Complexity Δ
...ava3/internal/schedulers/ComputationScheduler.java 97.53% <ø> (ø) 14 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 540 <0> (ø) ⬇️
...xjava3/internal/schedulers/NewThreadScheduler.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...va/io/reactivex/rxjava3/schedulers/Schedulers.java 100% <ø> (ø) 11 <0> (ø) ⬇️
...x/rxjava3/internal/schedulers/SingleScheduler.java 92.94% <ø> (ø) 15 <0> (ø) ⬇️
...tivex/rxjava3/internal/schedulers/IoScheduler.java 89.36% <ø> (ø) 9 <0> (ø) ⬇️
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 565 <1> (ø) ⬇️
...ava3/internal/schedulers/SchedulerPoolFactory.java 100% <100%> (ø) 19 <6> (+6) ⬆️
...main/java/io/reactivex/rxjava3/core/Scheduler.java 100% <100%> (ø) 11 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 88.19% <0%> (-6.25%) 2% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97790c6...2e7246d. Read the comment docs.

@cxbiao
Copy link

cxbiao commented Aug 28, 2019

ok

@akarnokd akarnokd merged commit 54d9279 into ReactiveX:3.x Aug 28, 2019
@akarnokd akarnokd deleted the SystemPropertyDirect3x branch August 28, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.properties access restriction.
3 participants