3.x: Fix blockingIterable not unblocking when force-disposed #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
Aug 21, 2019
src/main/java/io/reactivex/rxjava3/internal/operators/flowable/BlockingFlowableIterable.java
Outdated
Show resolved
Hide resolved
...main/java/io/reactivex/rxjava3/internal/operators/observable/BlockingObservableIterable.java
Outdated
Show resolved
Hide resolved
...st/java/io/reactivex/rxjava3/internal/operators/flowable/BlockingFlowableToIteratorTest.java
Show resolved
Hide resolved
…/BlockingFlowableIterable.java Co-Authored-By: Niklas Baudy <niklas.baudy@vanniktech.de>
…le/BlockingObservableIterable.java Co-Authored-By: Niklas Baudy <niklas.baudy@vanniktech.de>
vanniktech
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the iterator was cast to
Disposableand disposed, the subsequenthasNextwould block indefinitely. That interface is not intended to be part of the public API andIteratorin general does not support any form of official cancellation (unlike Stream). This PR makes sure that if that dispose is called, it unblocks the iterator.A separate PR will be posted for 2.x.
Related #6625