Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: add marbles to X.fromSupplier #6531

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

akarnokd
Copy link
Member

This PR adds marbles to the new fromSupplier operators:

Flowable:

image

Observable:

image

Maybe:

image

Single:

image

Completable:

image

@akarnokd akarnokd added this to the 3.0 milestone Jun 21, 2019
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #6531 into 3.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6531      +/-   ##
============================================
- Coverage     98.23%   98.23%   -0.01%     
- Complexity     6188     6189       +1     
============================================
  Files           680      680              
  Lines         44883    44883              
  Branches       6193     6193              
============================================
- Hits          44092    44090       -2     
- Misses          248      255       +7     
+ Partials        543      538       -5
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 566 <0> (ø) ⬇️
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 118 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 541 <0> (ø) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 172 <0> (ø) ⬇️
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 148 <0> (ø) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 88.88% <0%> (-6.77%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-2.72%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...tivex/internal/operators/single/SingleTimeout.java 98.33% <0%> (-1.67%) 2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 94.68% <0%> (-1.6%) 3% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98561ce...5151f64. Read the comment docs.

@akarnokd akarnokd merged commit e3b695a into ReactiveX:3.x Jun 21, 2019
@akarnokd akarnokd deleted the FromSupplierMarbles3x branch June 21, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants