Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add X.fromSupplier() #6529

Merged
merged 2 commits into from
Jun 20, 2019
Merged

3.x: Add X.fromSupplier() #6529

merged 2 commits into from
Jun 20, 2019

Conversation

akarnokd
Copy link
Member

This PR adds the fromSupplier operator to support the new Supplier interface.

The marble diagrams will be updated in a separate PR.

@akarnokd akarnokd added this to the 3.0 milestone Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (3.x@edb1f71). Click here to learn what that means.
The diff coverage is 96.93%.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.x    #6529   +/-   ##
======================================
  Coverage       ?   98.24%           
  Complexity     ?     6189           
======================================
  Files          ?      680           
  Lines          ?    44883           
  Branches       ?     6193           
======================================
  Hits           ?    44095           
  Misses         ?      253           
  Partials       ?      535
Impacted Files Coverage Δ Complexity Δ
...l/operators/observable/ObservableFromCallable.java 100% <ø> (ø) 5 <0> (?)
...ernal/operators/flowable/FlowableFromCallable.java 100% <ø> (ø) 4 <0> (?)
src/main/java/io/reactivex/Flowable.java 100% <100%> (ø) 566 <1> (?)
.../internal/operators/single/SingleFromSupplier.java 100% <100%> (ø) 5 <5> (?)
src/main/java/io/reactivex/Completable.java 100% <100%> (ø) 118 <1> (?)
src/main/java/io/reactivex/Observable.java 100% <100%> (ø) 541 <1> (?)
src/main/java/io/reactivex/Single.java 100% <100%> (ø) 148 <1> (?)
...operators/completable/CompletableFromSupplier.java 100% <100%> (ø) 4 <4> (?)
...ernal/operators/flowable/FlowableFromSupplier.java 100% <100%> (ø) 4 <4> (?)
...l/operators/observable/ObservableFromSupplier.java 100% <100%> (ø) 5 <5> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb1f71...59d1151. Read the comment docs.

@akarnokd akarnokd merged commit 98561ce into ReactiveX:3.x Jun 20, 2019
@akarnokd akarnokd deleted the FromSupplier3x branch June 20, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants