-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: remove test
from testXXX
method names, create a validator
#6525
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #6525 +/- ##
============================================
+ Coverage 98.16% 98.19% +0.03%
+ Complexity 6251 6248 -3
============================================
Files 675 675
Lines 45011 45011
Branches 6211 6211
============================================
+ Hits 44183 44199 +16
+ Misses 286 280 -6
+ Partials 542 532 -10
Continue to review full report at Codecov.
|
src/test/java/io/reactivex/validators/TestPrefixInMethodName.java
Outdated
Show resolved
Hide resolved
I was doing a massive set of changes to the test files myself so it would be great you rolled back the renames, kept the validator code but not fail when violations are found. I'll merge in #6526, then just the validator, then we can enable the offline/CI failure mode and fix the names in a fresh PR. |
I added |
Fix #6518.