Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix concatMapDelayError not continuing on fused inner source crash #6522

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

akarnokd
Copy link
Member

The Callable fused path didn't consider the error-delay settings and cut the sequence short.

Fixes: #6520

@akarnokd akarnokd added this to the 2.2 backlog milestone Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #6522 into 2.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6522      +/-   ##
============================================
+ Coverage     98.24%   98.24%   +<.01%     
+ Complexity     6294     6293       -1     
============================================
  Files           675      675              
  Lines         45165    45167       +2     
  Branches       6246     6247       +1     
============================================
+ Hits          44373    44375       +2     
+ Misses          251      248       -3     
- Partials        541      544       +3
Impacted Files Coverage Δ Complexity Δ
...internal/operators/flowable/FlowableConcatMap.java 98.13% <100%> (+0.01%) 6 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 94.69% <0%> (-3.54%) 11% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 95.78% <0%> (-2.54%) 10% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.56% <0%> (-2.18%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
...ternal/operators/flowable/FlowableSubscribeOn.java 96.61% <0%> (-1.7%) 2% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e8d48...cab93e5. Read the comment docs.

@akarnokd akarnokd merged commit b763ffa into ReactiveX:2.x Jun 20, 2019
@akarnokd akarnokd deleted the FlowableConcatMapDelayErrorFix branch June 20, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issus about Flowable concatMapDelayError
2 participants