3.x: Widen functional interface throws, replace Callable with Supplier #6511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #6511 +/- ##
============================================
- Coverage 98.22% 98.17% -0.06%
+ Complexity 6294 6293 -1
============================================
Files 675 675
Lines 45165 45170 +5
Branches 6246 6246
============================================
- Hits 44363 44344 -19
- Misses 250 288 +38
+ Partials 552 538 -14
Continue to review full report at Codecov.
|
lorenzpahl
reviewed
Jun 17, 2019
| * A functional interface (callback) that provides a single value or | ||
| * throws an exception. | ||
| * <p> | ||
| * Thins interface was added to allow throwing any subclass of {@link Throwable}s, |
lorenzpahl
reviewed
Jun 17, 2019
| @@ -22,16 +22,16 @@ | |||
| * <p> | |||
| * Implementors of {@link #call()} should not throw any exception. | |||
There was a problem hiding this comment.
The link should now point to get().
There was a problem hiding this comment.
Thanks. Posted an update with additional cleanups.
This was referenced Jun 19, 2019
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Feb 17, 2020
Motivation: Recently RxJava 3 has been released. https://github.com/ReactiveX/RxJava/releases/tag/v3.0.0 Armeria supports RxJava2 integration with `armeria-rxjava`. This PR migrates `RequestContextAssembly` from RxJava2 to RxJava3. RxJava 3 being based on Java 8 also supports seamless conversions between CompletionStage and Single, Maybe, Observable. Modifications: * Rename original `armeria-rxjava` to `armeria-rxjava2` * Make armeria-rxjava support RxJava 3 * Use built-in converter methods for ObservableResponseConverterFunction * Change `*Callable` to `*Supplier` ReactiveX/RxJava#6511 * Don't migrate `RequestContextScalarCallableCompletable` and `RequestContextCallableCompletable` There is no subclasses of `Completable` that implement `Supplier` * Delegate `reset()` in `ConnectableFlowable` https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#connectable-source-reset Result: You can now use RxJava 3 with Armeria. Fixes: line#2378
trustin
pushed a commit
to line/armeria
that referenced
this pull request
Feb 27, 2020
Motivation: Recently RxJava 3 has been released. https://github.com/ReactiveX/RxJava/releases/tag/v3.0.0 Armeria supports RxJava2 integration with `armeria-rxjava`. This PR migrates `RequestContextAssembly` from RxJava2 to RxJava3. RxJava 3 being based on Java 8 also supports seamless conversions between CompletionStage and Single, Maybe, Observable. Modifications: * Rename original `armeria-rxjava` to `armeria-rxjava2` * Make `armeria-rxjava` support RxJava 3 * Use built-in converter methods for ObservableResponseConverterFunction * Change `*Callable` to `*Supplier` ReactiveX/RxJava#6511 * Remove `assemblyContext.push()` in `RequestContextScalarCallable*.get()` * Don't need to push `RequestContext` for scalar type such as `Maybe.just(T)` * Delegate `reset()` method to `RequestContextConnectableFlowable`, `RequestContextConnectableObservable` https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#connectable-source-reset * Migrate `examples/context-propagation/rxjava` to RxJava 3 Result: You can now use RxJava 3 with Armeria. Fixes: #2378
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: Recently RxJava 3 has been released. https://github.com/ReactiveX/RxJava/releases/tag/v3.0.0 Armeria supports RxJava2 integration with `armeria-rxjava`. This PR migrates `RequestContextAssembly` from RxJava2 to RxJava3. RxJava 3 being based on Java 8 also supports seamless conversions between CompletionStage and Single, Maybe, Observable. Modifications: * Rename original `armeria-rxjava` to `armeria-rxjava2` * Make `armeria-rxjava` support RxJava 3 * Use built-in converter methods for ObservableResponseConverterFunction * Change `*Callable` to `*Supplier` ReactiveX/RxJava#6511 * Remove `assemblyContext.push()` in `RequestContextScalarCallable*.get()` * Don't need to push `RequestContext` for scalar type such as `Maybe.just(T)` * Delegate `reset()` method to `RequestContextConnectableFlowable`, `RequestContextConnectableObservable` https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#connectable-source-reset * Migrate `examples/context-propagation/rxjava` to RxJava 3 Result: You can now use RxJava 3 with Armeria. Fixes: line#2378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR widens the
throws Exceptionintothrows Throwablein the functional interfaces and adjustscatch (Exceptiontocatch(Throwablewhere needed.The major change is the replacement of
java.util.concurrent.Callablein almost all API withio.reactivex.functions.Supplierwhich is defined withthrows Throwable. Since subinterfaces can't widen the throws clause, only narrow it,Suppliercan't extendCallable.fromCallableremained in all base classes and a separate PR will introducefromSupplier.The single-valued fusion now works with
SupplierandScalarSuppliertypes instead ofCallableandScalarCallable(removed).