2.x: Fix concatEager to dispose sources & clean up properly. #6405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
concatMapEager
operator (which drives the static variants as well) to properly dispose and clean up the state of the operator upon cancelling/disposing the sequence.Flowable.concatMapEager
did not cancel the current active inner consumer, only the ones coming afterObservable.concatMapEager
did not dispose the main source of the inner observables.Both variants have received the same two unit tests to verify their behavior.
Fixes: #6404