2.x: Fix Completable.andThen(Completable) not running on observeOn scheduler. #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fined with observeOn.
…fined with observeOn.
akarnokd
requested changes
Jan 12, 2019
| @Test | ||
| public void andThenCompletableCompleteError() { | ||
| Completable.complete() | ||
| .andThen(Completable.error(new RuntimeException("test"))) |
There was a problem hiding this comment.
Please use TestException so we don't mistake them with any other RuntimeException failures.
| @@ -69,39 +63,4 @@ public void andThenMaybeError() { | |||
| .assertError(RuntimeException.class) | |||
| .assertErrorMessage("bla"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void andThenNoInterrupt() throws InterruptedException { | |||
There was a problem hiding this comment.
Why was this test removed without explanation?
There was a problem hiding this comment.
I moved it to CompletableAndThenCompletableTest since it specifically tested .andThen(Completable).
Codecov Report
@@ Coverage Diff @@
## 2.x #6362 +/- ##
============================================
- Coverage 98.28% 98.25% -0.04%
- Complexity 6285 6286 +1
============================================
Files 672 673 +1
Lines 44990 45021 +31
Branches 6223 6224 +1
============================================
+ Hits 44219 44234 +15
- Misses 243 250 +7
- Partials 528 537 +9
Continue to review full report at Codecov.
|
…fined with observeOn.
akarnokd
approved these changes
Jan 12, 2019
vanniktech
approved these changes
Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes unpredictable scheduler/thread used by
Completable.observeOn(...)andThen(Completable), since sometimes scheduler defined in observeOn(...) was not used. It was inconsistent with similar.andThen(Maybe)and.andThen(Single), since those are guaranteed to run second Completable using proper scheduler if defined with.observeOn.Fixes: #6354.