-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated java example in wiki #6331 #6351
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6351 +/- ##
============================================
- Coverage 98.27% 98.22% -0.06%
- Complexity 6285 6286 +1
============================================
Files 672 672
Lines 44990 44990
Branches 6223 6223
============================================
- Hits 44214 44191 -23
- Misses 246 259 +13
- Partials 530 540 +10
Continue to review full report at Codecov.
|
docs/How-To-Use-RxJava.md
Outdated
} | ||
|
||
}); | ||
Observable.fromArray(names).subscribe(s -> System.out.println("Hello " + s)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd instead show a Consumer<String>
and the lambda version, similar to the hello world example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated similar to hello world example.
Updated java example in docs/How-To-Use-RxJava.md file with java 8 version.
Resolves: #6331