Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add missing Completable marbles (+19, 07/19a) #6097

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

akarnokd
Copy link
Member

This PR add even more missing marbles to Completable (tracked by #5789):

delay

image
image
image

doOnX

image
image
image
image
image
image
image

doFinally

image

onErrorComplete

image
image

onErrorResumeNext

image

onTerminateDetach

image

mergeWith

image

concatWith

image

observeOn

image

hide

image

@akarnokd akarnokd added this to the 2.2 milestone Jul 19, 2018
@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #6097 into 2.x will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #6097      +/-   ##
===========================================
- Coverage     98.3%   98.23%   -0.07%     
- Complexity    6196     6199       +3     
===========================================
  Files          667      667              
  Lines        44862    44862              
  Branches      6213     6213              
===========================================
- Hits         44102    44071      -31     
- Misses         231      242      +11     
- Partials       529      549      +20
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 117 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 84.96% <0%> (-9.81%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-4.48%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 95.72% <0%> (-2.57%) 2% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 97.44% <0%> (-1.28%) 11% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 94.11% <0%> (-1.07%) 5% <0%> (ø)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 98.2% <0%> (-0.9%) 59% <0%> (-1%)
...operators/observable/ObservableMergeWithMaybe.java 99.1% <0%> (-0.9%) 2% <0%> (ø)
...l/operators/observable/ObservableTimeoutTimed.java 99.15% <0%> (-0.85%) 3% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c63b6...982028c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants