-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marble diagrams for Single.repeat operators #6081
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6081 +/- ##
============================================
- Coverage 98.25% 98.24% -0.02%
+ Complexity 6195 6194 -1
============================================
Files 667 667
Lines 44856 44856
Branches 6211 6211
============================================
- Hits 44074 44068 -6
- Misses 237 244 +7
+ Partials 545 544 -1
Continue to review full report at Codecov.
|
I see few errors. Timeline for flowables should end with error/complete event and should not continue beyond them. I'll update that tomorrow |
It would be great if you linked the diagrams in the PR text. |
Could you also add shadows to the marbles and X? |
Updated images and PR comment |
|
Thanks! PR is now updated |
Here are marbles for
repeat
,repeat(times)
andrepeatWhen
operator in #5788Please let me know if I need to change anything on the diagram itself. If not, please send me URL when you upload image within the project so I can change URL for the marble in the PR.
I intentionally added two diagrams for
repeatWhen
as I would say its interesting case that people should be aware of.EDIT:
Here are marbles
repeat
operator:repeat(count)
operator:repeatWhen
operator: