Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Improve class Javadoc of Single, Maybe and Completable #6080

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

akarnokd
Copy link
Member

This PR expands the Javadocs of Single, Maybe and Completable where the latter also receives an explanation marble:

image

Please let me know if there is any property worthy of mentioning in the class' JavaDocs as well as please look out for copy-paste mistakes.

@akarnokd akarnokd added this to the 2.2 milestone Jul 13, 2018
@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #6080 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6080      +/-   ##
============================================
- Coverage     98.29%   98.28%   -0.01%     
+ Complexity     6197     6193       -4     
============================================
  Files           667      667              
  Lines         44856    44856              
  Branches       6211     6211              
============================================
- Hits          44090    44088       -2     
  Misses          233      233              
- Partials        533      535       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 171 <0> (ø) ⬇️
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 146 <0> (ø) ⬇️
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 116 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-5.23%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-2.78%) 56% <0%> (-2%)
...nternal/operators/observable/ObservableCreate.java 95.72% <0%> (-2.57%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...internal/operators/flowable/FlowableFromArray.java 94.91% <0%> (-1.7%) 3% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c1da0...ce5cb1c. Read the comment docs.

@akarnokd akarnokd merged commit 535ab35 into ReactiveX:2.x Jul 14, 2018
@akarnokd akarnokd deleted the BaseClassJavadocExpansion branch July 14, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants