Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5980 made subscribeActual protected #6052

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

sircelsius
Copy link
Contributor

@sircelsius sircelsius commented Jun 20, 2018

Proposal

Changed subscribeActual from public to protected, as described in #5980.

How I tested

Ran tests locally, please let me know if I missed part of the contributing guidelines 👼

Fixes: #5980.

@akarnokd akarnokd added this to the 2.2 milestone Jun 20, 2018
@akarnokd
Copy link
Member

/cc @vanniktech, @artem-zinnatullin, @davidmoten

Strictly speaking, this is technically a breaking change on something that shouldn't be in use at all by external developers. I'm fine with this change for 2.1.15.

@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #6052 into 2.x will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #6052      +/-   ##
===========================================
+ Coverage     98.24%   98.3%   +0.06%     
- Complexity     6188    6195       +7     
===========================================
  Files           666     666              
  Lines         44802   44802              
  Branches       6206    6206              
===========================================
+ Hits          44014   44044      +30     
+ Misses          241     227      -14     
+ Partials        547     531      -16
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/reactivex/subjects/PublishSubject.java 100% <ø> (ø) 38 <0> (ø) ⬇️
...java/io/reactivex/processors/PublishProcessor.java 100% <ø> (ø) 43 <0> (ø) ⬇️
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-2.16%) 9% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-2.14%) 5% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-1.67%) 2% <0%> (ø)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...perators/mixed/ObservableConcatMapCompletable.java 99.24% <0%> (-0.76%) 3% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 90.19% <0%> (-0.66%) 2% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b852d...c319722. Read the comment docs.

Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants