-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5980 made subscribeActual protected #6052
#5980 made subscribeActual protected #6052
Conversation
/cc @vanniktech, @artem-zinnatullin, @davidmoten Strictly speaking, this is technically a breaking change on something that shouldn't be in use at all by external developers. I'm fine with this change for 2.1.15. |
Codecov Report
@@ Coverage Diff @@
## 2.x #6052 +/- ##
===========================================
+ Coverage 98.24% 98.3% +0.06%
- Complexity 6188 6195 +7
===========================================
Files 666 666
Lines 44802 44802
Branches 6206 6206
===========================================
+ Hits 44014 44044 +30
+ Misses 241 227 -14
+ Partials 547 531 -16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am as well.
Proposal
Changed
subscribeActual
frompublic
toprotected
, as described in #5980.How I tested
Ran tests locally, please let me know if I missed part of the contributing guidelines 👼
Fixes: #5980.