Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.X: Fix disposed LambdaObserver onError to route to global error handler #6036

Merged
merged 1 commit into from
Jun 9, 2018
Merged

2.X: Fix disposed LambdaObserver onError to route to global error handler #6036

merged 1 commit into from
Jun 9, 2018

Conversation

hanschua
Copy link
Contributor

@hanschua hanschua commented Jun 9, 2018

Fix the behaviour of LambdaObserver when disposed to route to the global error handler

Fixes #6025

@akarnokd akarnokd added this to the 2.2 milestone Jun 9, 2018
@codecov
Copy link

codecov bot commented Jun 9, 2018

Codecov Report

Merging #6036 into 2.x will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #6036      +/-   ##
===========================================
- Coverage     98.3%   98.28%   -0.03%     
+ Complexity    6175     6172       -3     
===========================================
  Files          665      665              
  Lines        44729    44730       +1     
  Branches      6205     6205              
===========================================
- Hits         43973    43964       -9     
- Misses         222      229       +7     
- Partials       534      537       +3
Impacted Files Coverage Δ Complexity Δ
...o/reactivex/internal/observers/LambdaObserver.java 100% <100%> (ø) 14 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-5.98%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.92%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <0%> (-2.25%) 60% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 97.02% <0%> (-2.13%) 11% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
...java/io/reactivex/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c8862...309cd1e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants