Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix Single.takeUntil, Maybe.takeUntil dispose behavior #6019

Merged
merged 1 commit into from
May 25, 2018

Conversation

akarnokd
Copy link
Member

Fix the dispose behavior of the Single.takeUntil and Maybe.takeUntil operators.

Tests were also added to the other 3 takeUntil variants (for Completable, it is delegated to amb).

Fixes: #6018

@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #6019 into 2.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6019      +/-   ##
============================================
+ Coverage     98.27%   98.28%   +<.01%     
+ Complexity     6163     6161       -2     
============================================
  Files           659      659              
  Lines         44519    44521       +2     
  Branches       6201     6201              
============================================
+ Hits          43753    43757       +4     
+ Misses          231      229       -2     
  Partials        535      535
Impacted Files Coverage Δ Complexity Δ
...ernal/operators/maybe/MaybeTakeUntilPublisher.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...vex/internal/operators/single/SingleTakeUntil.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 95.72% <0%> (-3.42%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 96.66% <0%> (-1.67%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 94.02% <0%> (-1.5%) 2% <0%> (ø)
...internal/operators/flowable/FlowableSwitchMap.java 95.28% <0%> (-1.42%) 3% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f5ef8...794cd19. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants