Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: deprecate getValues() in Subjects/Processors #5982

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

akarnokd
Copy link
Member

This PR deprecates the getValues() and getValues(T[]) methods in AsyncSubject, BehaviorSubject, AsyncProcessor and BehaviorProcessor.

These methods were remnants of an early 2.x API design where Subject itself had these methods for the sake of ReplaySubject and SerializedSubject and thus every other subject type had to implement them. The listed subjects and processors above have at most one value accessible via getValue() which can then be assigned to an array index manually if needed.

@akarnokd akarnokd added this to the 3.0 milestone Apr 29, 2018
@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #5982 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5982      +/-   ##
============================================
+ Coverage     98.23%   98.26%   +0.03%     
+ Complexity     6053     6050       -3     
============================================
  Files           656      656              
  Lines         44078    44078              
  Branches       6118     6118              
============================================
+ Hits          43299    43314      +15     
+ Misses          236      230       -6     
+ Partials        543      534       -9
Impacted Files Coverage Δ Complexity Δ
...n/java/io/reactivex/processors/AsyncProcessor.java 99.08% <ø> (ø) 52 <0> (ø) ⬇️
...in/java/io/reactivex/subjects/BehaviorSubject.java 98.92% <ø> (ø) 54 <0> (ø) ⬇️
.../main/java/io/reactivex/subjects/AsyncSubject.java 99.06% <ø> (ø) 52 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 98.2% <ø> (ø) 59 <0> (ø) ⬇️
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 93.04% <0%> (-1.07%) 5% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b9628...0b87107. Read the comment docs.

Copy link
Contributor

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@akarnokd akarnokd merged commit 70f9a83 into ReactiveX:2.x Apr 30, 2018
@akarnokd akarnokd deleted the SubjectGetValuesDeprecation branch April 30, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants