2.x: deprecate getValues() in Subjects/Processors #5982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
getValues()
andgetValues(T[])
methods inAsyncSubject
,BehaviorSubject
,AsyncProcessor
andBehaviorProcessor
.These methods were remnants of an early 2.x API design where
Subject
itself had these methods for the sake ofReplaySubject
andSerializedSubject
and thus every other subject type had to implement them. The listed subjects and processors above have at most one value accessible viagetValue()
which can then be assigned to an array index manually if needed.