-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Add Single.ignoreElement, deprecate toCompletable #5957
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5957 +/- ##
============================================
+ Coverage 98.23% 98.26% +0.02%
- Complexity 6016 6018 +2
============================================
Files 656 656
Lines 44036 44037 +1
Branches 6100 6100
============================================
+ Hits 43259 43272 +13
+ Misses 238 226 -12
Partials 539 539
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We deprecate a method that's stable and then add a new one that should be used that's experimental.
Does not seem right to me.
I'd be completely fine with |
Then let's do it. |
Rename-deprecate
Single.toCompletable
toignoreElement
to be in line with the same operator in the other classes and also indicate more clearly in the method name that it ignores the element.In addition, the marbles have been updated on both
Single
andMaybe
of this operator.