Removed TERMINATED check in onNext

[kjkrum]

TERMINATED is an empty array, so iterating over it would be harmless. The cost of the check is probably minuscule, but it was imposed on the common case where the subject is not terminated. In essence, it was optimizing for misuse of the API.

[codecov]

Codecov Report

Merging #5942 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##                2.x   #5942      +/-   ##
===========================================
- Coverage     98.23%   98.2%   -0.03%     
+ Complexity     6016    6015       -1     
===========================================
  Files           656     656              
  Lines         44040   44036       -4     
  Branches       6102    6100       -2     
===========================================
- Hits          43262   43247      -15     
- Misses          232     237       +5     
- Partials        546     552       +6

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/io/reactivex/subjects/PublishSubject.java	100% <ø> (ø)	38 <0> (-1)	⬇️
...java/io/reactivex/processors/PublishProcessor.java	100% <ø> (ø)	43 <0> (-1)	⬇️
...l/operators/observable/ObservableFlatMapMaybe.java	90.19% <0%> (-5.89%)	2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java	91.08% <0%> (-3.97%)	2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java	96.46% <0%> (-2.66%)	11% <0%> (+1%)
...va/io/reactivex/internal/queue/SpscArrayQueue.java	97.61% <0%> (-2.39%)	22% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java	89.55% <0%> (-2.24%)	2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java	92.7% <0%> (-2.19%)	2% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java	97.02% <0%> (-2.13%)	11% <0%> (ø)
...activex/internal/schedulers/ScheduledRunnable.java	98.07% <0%> (-1.93%)	29% <0%> (-1%)
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd4ac2...6dd7025. Read the comment docs.

[akarnokd]

Could you also update PublishProcessor?

[kjkrum]

@akarnokd Done.