Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Allow @SchedulerSupport on constructors. #5940

Merged
merged 1 commit into from
Mar 31, 2018
Merged

2.x: Allow @SchedulerSupport on constructors. #5940

merged 1 commit into from
Mar 31, 2018

Conversation

vanniktech
Copy link
Collaborator

Motivation behind this is having a class which takes multiple constructor parameters where one can be a Scheduler with a default and a custom overload. In both cases I'd want to slam @SchedulerSupport on it so it can be handled properly by static analysis as well.

@codecov
Copy link

codecov bot commented Mar 31, 2018

Codecov Report

Merging #5940 into 2.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5940      +/-   ##
============================================
+ Coverage     98.23%   98.24%   +<.01%     
- Complexity     6016     6020       +4     
============================================
  Files           656      656              
  Lines         44040    44040              
  Branches       6102     6102              
============================================
+ Hits          43262    43266       +4     
- Misses          232      235       +3     
+ Partials        546      539       -7
Impacted Files Coverage Δ Complexity Δ
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-6.54%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-2.99%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-2.72%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 93.58% <0%> (-2.68%) 5% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd4ac2...8e806a2. Read the comment docs.

Copy link
Contributor

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artem-zinnatullin
Copy link
Contributor

nit: maybe rename PR title to 2.x: Allow @SchedulerSupport on constructors.?

"Also" just distracts from the subject :)

@akarnokd akarnokd merged commit 1706fe1 into ReactiveX:2.x Mar 31, 2018
@vanniktech vanniktech deleted the schedulersupportconstructor branch March 31, 2018 08:06
@vanniktech vanniktech changed the title 2.x: Also allow @SchedulerSupport on constructors. 2.x: Allow @SchedulerSupport on constructors. Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants