Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @NonNull annotations to create methods of Subjects and Processors #5930

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

vpriscan
Copy link

I am annotating *Subject's and *Processor's create methods with @nonnull annotations to remove compiler's nullability warnings when calling the methods from Kotlin language.

@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #5930 into 2.x will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5930      +/-   ##
============================================
+ Coverage     98.17%   98.21%   +0.04%     
- Complexity     6017     6020       +3     
============================================
  Files           656      656              
  Lines         44040    44040              
  Branches       6102     6102              
============================================
+ Hits          43237    43256      +19     
+ Misses          248      245       -3     
+ Partials        555      539      -16
Impacted Files Coverage Δ Complexity Δ
...java/io/reactivex/subjects/CompletableSubject.java 100% <ø> (ø) 36 <0> (ø) ⬇️
...java/io/reactivex/processors/UnicastProcessor.java 100% <ø> (ø) 68 <0> (ø) ⬇️
.../java/io/reactivex/processors/ReplayProcessor.java 99.58% <ø> (ø) 52 <0> (ø) ⬇️
...in/java/io/reactivex/subjects/BehaviorSubject.java 98.92% <ø> (ø) 54 <0> (ø) ⬇️
...ain/java/io/reactivex/subjects/PublishSubject.java 100% <ø> (ø) 39 <0> (ø) ⬇️
.../main/java/io/reactivex/subjects/AsyncSubject.java 99.06% <ø> (ø) 52 <0> (ø) ⬇️
.../main/java/io/reactivex/subjects/MaybeSubject.java 100% <ø> (ø) 46 <0> (ø) ⬇️
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <ø> (-1.35%) 60 <0> (+1)
...java/io/reactivex/processors/PublishProcessor.java 98.23% <ø> (-1.77%) 43 <0> (-1)
...ain/java/io/reactivex/subjects/UnicastSubject.java 100% <ø> (ø) 65 <0> (ø) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0298ab...94973c1. Read the comment docs.

@akarnokd akarnokd added the 2.x label Mar 23, 2018
@akarnokd akarnokd added this to the 2.2 milestone Mar 23, 2018
@akarnokd akarnokd merged commit 5c58f82 into ReactiveX:2.x Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants