Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nullable annotations to subjects #5890

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Added nullable annotations to subjects #5890

merged 1 commit into from
Mar 5, 2018

Conversation

bangarharshit
Copy link
Contributor

Adding nullable annotations to subjects. The throwable and getValue methods are annotated with Nullable.

Quick question about styling - In some places, javadocs has trailing whitespaces but it is absent in other places. Is there a styling policy around that? Intellij is removing the trailed whitespace automatically.

@codecov
Copy link

codecov bot commented Mar 5, 2018

Codecov Report

Merging #5890 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #5890      +/-   ##
===========================================
- Coverage     97.63%   97.6%   -0.03%     
- Complexity     5947    5948       +1     
===========================================
  Files           655     655              
  Lines         43860   43860              
  Branches       6098    6098              
===========================================
- Hits          42821   42811      -10     
- Misses          325     328       +3     
- Partials        714     721       +7
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/subjects/AsyncSubject.java 99.06% <ø> (ø) 52 <0> (ø) ⬇️
.../java/io/reactivex/subjects/SerializedSubject.java 95.78% <ø> (ø) 27 <0> (ø) ⬇️
...java/io/reactivex/subjects/CompletableSubject.java 100% <ø> (ø) 36 <0> (ø) ⬇️
...ain/java/io/reactivex/subjects/PublishSubject.java 100% <ø> (ø) 39 <0> (ø) ⬇️
.../main/java/io/reactivex/subjects/MaybeSubject.java 100% <ø> (ø) 46 <0> (ø) ⬇️
...in/java/io/reactivex/subjects/BehaviorSubject.java 96.23% <ø> (ø) 54 <0> (ø) ⬇️
...ain/java/io/reactivex/subjects/UnicastSubject.java 100% <ø> (ø) 65 <0> (ø) ⬇️
...main/java/io/reactivex/subjects/ReplaySubject.java 97.56% <ø> (ø) 49 <0> (ø) ⬇️
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.78% <0%> (-2.9%) 2% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba1d35...aaa7b3f. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 milestone Mar 5, 2018
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace was added by accident and should not be there so it's fine to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants