Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Upgrade the algorithm of Observable.timeout(time|selector) operators #5886

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Mar 4, 2018

This PR improves the algorithms of the Observable.timeout(time) and Observable.timeout(selector) operators to match their Flowable counterparts implemented in #5661.

In addition, coverage of the Flowable counterparts have been improved by synchronizing the unit tests.

Note that they were the last users of ObserverFullArbiter and FullArbiterObserver which are now removed.

Closes #5882.

@akarnokd akarnokd added this to the 2.2 milestone Mar 4, 2018
@codecov
Copy link

codecov bot commented Mar 4, 2018

Codecov Report

Merging #5886 into 2.x will increase coverage by 0.04%.
The diff coverage is 99.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5886      +/-   ##
============================================
+ Coverage     97.41%   97.45%   +0.04%     
+ Complexity     5976     5946      -30     
============================================
  Files           657      655       -2     
  Lines         43960    43877      -83     
  Branches       6128     6109      -19     
============================================
- Hits          42824    42761      -63     
+ Misses          346      343       -3     
+ Partials        790      773      -17
Impacted Files Coverage Δ Complexity Δ
...ternal/operators/observable/ObservableTimeout.java 100% <100%> (+3.47%) 3 <0> (ø) ⬇️
...l/operators/observable/ObservableTimeoutTimed.java 99.15% <98.7%> (+5.55%) 3 <0> (-1) ⬇️
.../io/reactivex/internal/functions/ObjectHelper.java 94.73% <0%> (-5.27%) 20% <0%> (-1%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...ernal/operators/observable/ObservableInterval.java 96.42% <0%> (-3.58%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.3% <0%> (-2.9%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 95.76% <0%> (-2.65%) 54% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 92.3% <0%> (-2.57%) 6% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-2.5%) 2% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea2c95...e55dcd4. Read the comment docs.

Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants